Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header providers for multipart request #145

Open
wants to merge 1 commit into
base: update-xcresultparser
Choose a base branch
from

Conversation

mrandrewsmith
Copy link
Collaborator

The problem

builder.add(provider: provider) was ignored for multipart requests

What is done

  • Added header providers for multipart request
  • Created tests for new functionality

@mrandrewsmith mrandrewsmith self-assigned this Dec 25, 2024
@mrandrewsmith mrandrewsmith changed the base branch from master to update-xcresultparser December 25, 2024 13:45
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (1aaa23c) to head (fda636e).
Report is 1 commits behind head on update-xcresultparser.

Files with missing lines Patch % Lines
NodeKit/NodeKit/Chains/ServiceChainProvider.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           update-xcresultparser     #145      +/-   ##
=========================================================
+ Coverage                  92.23%   93.26%   +1.03%     
=========================================================
  Files                         85       85              
  Lines                       1326     1826     +500     
=========================================================
+ Hits                        1223     1703     +480     
- Misses                       103      123      +20     
Flag Coverage Δ
tests 93.26% <81.81%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants